Skip to content

Conversation

m2jean
Copy link
Contributor

@m2jean m2jean commented Mar 23, 2023

Summary

The current description indicates that when the return value is true, it means the menus are left-aligned. However, it's the opposite for SPI_GETMENUDROPALIGNMENT for the Win32 API SystemParametersInfoA, and the source code doesn't do any negation.

Fixes #7920

@m2jean m2jean requested a review from a team as a code owner March 23, 2023 13:59
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-WPF Issues or PRs that relate to WPF or XAML. labels Mar 23, 2023
@m2jean
Copy link
Contributor Author

m2jean commented Mar 23, 2023

@dotnet-policy-service agree

@learn-build-service-prod
Copy link

Learn Build status updates of commit 017bf89:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows/SystemParameters.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m2jean

@gewarren gewarren closed this Sep 23, 2025
@gewarren gewarren reopened this Sep 23, 2025
@gewarren gewarren enabled auto-merge (squash) September 23, 2025 00:22
@gewarren gewarren merged commit 480e703 into dotnet:main Sep 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-WPF Issues or PRs that relate to WPF or XAML. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of SystemParameters.MenuDropAlignment is backwards
2 participants